fix(andreknie.de): close data lifecycle review gaps

privat/CV/andreknie.de/server/routes/contact.js

@@ -8,26 +8,28 @@ const router = Router()
 
 router.post('/', contactLimiter, antiSpam, async (req, res) => {
   const { name, email, message } = req.body
+  let token
   const errors = {}
   if (!name || name.trim().length === 0) errors.name = 'Name ist erforderlich.'
   if (name && name.length > 100) errors.name = 'Max. 100 Zeichen.'
-  if (!email || !/^[^\s@]+@[^\s@]+\.[^\s@]+$/.test(email)) errors.email = 'Gueltige E-Mail erforderlich.'
+  if (!email || !/^[^\s@]+@[^\s@]+\.[^\s@]+$/.test(email)) errors.email = 'Gültige E-Mail erforderlich.'
   if (!message || message.trim().length === 0) errors.message = 'Nachricht ist erforderlich.'
   if (message && message.length > 2000) errors.message = 'Max. 2000 Zeichen.'
 
   if (Object.keys(errors).length > 0) return res.status(400).json({ errors })
 
   try {
-    const token = await createToken('contact', { name, email, message }, 24)
+    token = await createToken('contact', { name, email, message }, 24)
     await sendConfirmationEmail(email, 'contact', token)
-    res.status(201).json({ ok: true, message: 'Bestaetigungs-E-Mail gesendet.' })
+    res.status(201).json({ ok: true, message: 'Bestätigungs-E-Mail gesendet.' })
   } catch (error) {
+    if (token) await completeToken(token)
     res.status(error instanceof MailerNotReadyError ? 503 : 502).json({ error: 'Die Anfrage konnte derzeit nicht versendet werden.' })
   }
 })
 
 router.get('/confirm/:token', async (req, res) => {
-  const baseUrl = process.env.BASE_URL || ''
+  const baseUrl = (process.env.BASE_URL || '').replace(/\/+$/, '')
   const entry = await reserveToken(req.params.token)
   if (!entry) return res.redirect(baseUrl + '/bestaetigung?status=error')
 
@@ -35,9 +37,9 @@ router.get('/confirm/:token', async (req, res) => {
     await sendStakeholderNotification('contact', entry.data)
     await completeToken(req.params.token)
     res.redirect(baseUrl + '/bestaetigung?status=success')
-  } catch (error) {
+  } catch {
     await releaseToken(req.params.token)
-    res.status(error instanceof MailerNotReadyError ? 503 : 502).redirect(baseUrl + '/bestaetigung?status=error')
+    res.redirect(baseUrl + '/bestaetigung?status=error')
   }
 })