fix(andreknie.de): close data lifecycle review gaps
This commit is contained in:
@@ -8,9 +8,10 @@ const router = Router()
|
||||
|
||||
router.post('/', talkRequestLimiter, antiSpam, async (req, res) => {
|
||||
const { name, email, event_name, topic, message } = req.body
|
||||
let token
|
||||
const errors = {}
|
||||
if (!name || name.trim().length === 0) errors.name = 'Name ist erforderlich.'
|
||||
if (!email || !/^[^\s@]+@[^\s@]+\.[^\s@]+$/.test(email)) errors.email = 'Gueltige E-Mail erforderlich.'
|
||||
if (!email || !/^[^\s@]+@[^\s@]+\.[^\s@]+$/.test(email)) errors.email = 'Gültige E-Mail erforderlich.'
|
||||
if (!event_name || event_name.trim().length === 0) errors.event_name = 'Eventname ist erforderlich.'
|
||||
if (!topic || topic.trim().length === 0) errors.topic = 'Thema ist erforderlich.'
|
||||
if (!message || message.trim().length === 0) errors.message = 'Nachricht ist erforderlich.'
|
||||
@@ -19,16 +20,17 @@ router.post('/', talkRequestLimiter, antiSpam, async (req, res) => {
|
||||
if (Object.keys(errors).length > 0) return res.status(400).json({ errors })
|
||||
|
||||
try {
|
||||
const token = await createToken('talk-request', { name, email, event_name, topic, message }, 48)
|
||||
token = await createToken('talk-request', { name, email, event_name, topic, message }, 48)
|
||||
await sendConfirmationEmail(email, 'talk-request', token)
|
||||
res.status(201).json({ ok: true, message: 'Bestaetigungs-E-Mail gesendet.' })
|
||||
res.status(201).json({ ok: true, message: 'Bestätigungs-E-Mail gesendet.' })
|
||||
} catch (error) {
|
||||
if (token) await completeToken(token)
|
||||
res.status(error instanceof MailerNotReadyError ? 503 : 502).json({ error: 'Die Anfrage konnte derzeit nicht versendet werden.' })
|
||||
}
|
||||
})
|
||||
|
||||
router.get('/confirm/:token', async (req, res) => {
|
||||
const baseUrl = process.env.BASE_URL || ''
|
||||
const baseUrl = (process.env.BASE_URL || '').replace(/\/+$/, '')
|
||||
const entry = await reserveToken(req.params.token)
|
||||
if (!entry) return res.redirect(baseUrl + '/bestaetigung?status=error')
|
||||
|
||||
@@ -36,9 +38,9 @@ router.get('/confirm/:token', async (req, res) => {
|
||||
await sendStakeholderNotification('talk-request', entry.data)
|
||||
await completeToken(req.params.token)
|
||||
res.redirect(baseUrl + '/bestaetigung?status=success')
|
||||
} catch (error) {
|
||||
} catch {
|
||||
await releaseToken(req.params.token)
|
||||
res.status(error instanceof MailerNotReadyError ? 503 : 502).redirect(baseUrl + '/bestaetigung?status=error')
|
||||
res.redirect(baseUrl + '/bestaetigung?status=error')
|
||||
}
|
||||
})
|
||||
|
||||
|
||||
Reference in New Issue
Block a user